Damien L-G
Damien L-G
> I have a broader question here: What role should tests for Kokkos Tools play? Ensure that the tools behave as they are supposed to and are compatible with Kokkos...
Why was that not caught by the CI?
Please add a reference to the relevant TriBITS documentation. I just had a glance through it and had the impression that one can only disable "advanced" tests. Yet we don't...
Found it https://tribitspub.github.io/TriBITS/users_guide/index.html#disabling-tests-externally-tribits-add-test So it does support `tribits_add_test()`
I would be curious to hear why this support for disabling tests is needed that cannot just be done with an exclude regex argument to ctest. Any idea?
OK we can do DISABLE and RUN_SERIAL as properties on the tests. Any good reason why you would need these extra args rather than setting the ENVIRONMENT property. You would...
Are you sure about the name? Shouldn't it be Kokkos_AlgorithmsUnitTest_Bla
> All the changes here are in the branch for Kokkos-standalone so it shouldn't actually have any impact for a Trilinos build as of now. 🤦 So close this and...
This is a sore point. As far as I know, no one in our team likes the 4.X.0Y scheme, but we decided we would stick with it for the 4.X...
`MemoryPool` is considered an implementation detail that was exclusively used in tasking. It was never intended for general use. Declaring directly in the `Kokkos` namespace (instead of `Kokkos::Impl`) was an...