Damien L-G
Damien L-G
This is a good question. We already lifted the `volatile`-qualified functions requirement in `develop` (in #4931 and follow-up PRs) We intend for all users to define the non-qualified versions. It...
Also this does not eliminate all of the multiple inheritance cast to some arbitrary parent trick to access property value
Consider having simple abstractions you can compose with such as * `has_property() -> bool` to check whether `ViewCtorProp` has some given property. Analogous to the `has_execution_space` or `has_label` members but...
Please justify that the unit test added here cannot ran faster and achieve the same thing. (I would probably already have complained for more than a few seconds.) ``` test...
We may cherry-pick into RC 3.7 but we don't absolutely have to
> Does this actually fix something? Should fix the error reported in the description https://github.com/kokkos/kokkos/issues/5320#issuecomment-1209623403
Did you check if it was broken with previous releases? Is the issue sensitive to the backend that is used? To the compiler ?(Compiler version you provide and CMake log...
Actually we do (I had to look it up) https://github.com/kokkos/kokkos/blob/e765d320fe0d5bbb7ff68b4a8b2bbd81f1d80a0e/core/src/Kokkos_ExecPolicy.hpp#L201-L207 and, as a side comment, I don't quite understand why we don't just update `*this` and return a reference to...
Did you try on AMD?
> > Did you try on AMD? > > No not yet. AMD is still giving linktime issues that I need to debug. Please do so. You may comment out...