Damien L-G comments

Results 492 comments of


                                            Damien L-G

`Kokkos::subview` does not compile for a rank-zero view: missing one template specialization for `Kokkos::Impl::SubviewLegalArgsCompileTime`

You need to fence in the 1st overload of `fetch_device_view_element` before you return `val_h`. But sure you can open a PR for it.

Introduce `Kokkos::TypeInfo<T>::name()` as a replacement for `typeid(T).name()`

I purposefully did not yet update the `kokkosp.kernel_name.*` tests to highlight how this PR impacts the tooling interface. Here is a summary of what changed for a few compilers: **MSVC**...

Introduce `Kokkos::TypeInfo<T>::name()` as a replacement for `typeid(T).name()`

Extracting here one of the test case: | | Before | After| | --- | --- | --- | | MSVC | "class " | "const class \`anonymous-namespace'::test_kernel_name_parallel_for::" | |...

Introduce `Kokkos::TypeInfo<T>::name()` as a replacement for `typeid(T).name()`

Note that while the length of defaulted kernel names generally increases with lambdas, it often decreases for templated functors. That is to say, I am showing you the worse case...

Introduce `Kokkos::TypeInfo<T>::name()` as a replacement for `typeid(T).name()`

Retest this please

Introduce `Kokkos::TypeInfo<T>::name()` as a replacement for `typeid(T).name()`

Retest this please

Introduce `Kokkos::TypeInfo<T>::name()` as a replacement for `typeid(T).name()`

Ignoring NVHPC segfault in the OpenACC build. Everything else passed.

User Documentation of Kokkos Tools TPL Connectors

What prevents you to create a docs/ directory and document in a markdown file?

CMake Config forces launch_compiler

I am torn on this. I feel like it is a "components" misuse.

Put in tests for sampler

> > > Your test is really weak. It will pass if the sampler does nothing and just always forward to the underlying tool. > > > > > >...