Liam Miller-Cushon

icon indicating a website link cushon.org icon indicating an email [email protected]

Results 378 comments of Liam Miller-Cushon

8328995: Launcher can't open jar files where the offset of the manifest is >4GB

> To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!...

8328995: Launcher can't open jar files where the offset of the manifest is >4GB

@bridgekeeper please keep this open

8328995: Launcher can't open jar files where the offset of the manifest is >4GB

bridgekeeper please keep open

8328995: Launcher can't open jar files where the offset of the manifest is >4GB

For what it's worth I have been testing the current version of the PR at Google, and have verified it allows jars with >4GB offsets to be launched, and we...

8328995: Launcher can't open jar files where the offset of the manifest is >4GB

bridgekeeper please keep this open for now

Incorrect fix ranges for checkstyle

I saw another recent example of a report for checkstyle where the fixed range doesn't make sense: https://issues.oss-fuzz.com/issues/415382662

8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries (JDK-8225377)

/issue add JDK-8341779

8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries (JDK-8225377)

/issue add JDK-8340024

8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries (JDK-8225377)

/approval JDK-8341779 request for backport. Fixes a bug in javac's implementation of TypeMirror to allow accessing type-use annotations on types loaded from class files. Risk: The feature will be disabled...

8341779: [REDO BACKPORT] type annotations are not visible to javac plugins across compilation boundaries (JDK-8225377)

/approval JDK-8340024 request for backport. No-risk clean-up change for code hygiene, which also also included in JDK 21 as part of the JDK-8341779 redo, see https://git.openjdk.org/jdk21u-dev/pull/1671.