Liam Miller-Cushon

Are you using Lombok? I wonder if it's similar to #1250

Thanks for the investigation, adding a disclaimer to https://errorprone.info/docs/flags#maven sounds good to me. Would you be willing to also report the bug against maven, if you haven't already, since it...

I think I understand what's happening in #4595, @xenoterracide if you get a chance could you try adding `-XDshould-stop.ifError=FLOW` to this build and see if the false positives go away?

> Afaict it determines what can be parsed but not how it'll be formatted. Right, it'll parse at whatever the newest language level supported by the runtime is, and shouldn't...

I just pushed another release, and am planning to update the minimum supported JDK to 17 for the next release after that one: https://github.com/google/google-java-format/releases/tag/v1.24.0

I pushed 1.25.0, which raises the minimum supported JDK to JDK 17: https://github.com/google/google-java-format/releases/tag/v1.25.0 (I previously mistakenly updated the release notes for 1.24.0, I have finished publishing the 1.25.0 release and...

/approval request Backporting this change fixes a bug with invokedynamic-based string concatenation. The fix has received real-world testing since 2022, including in JDK 21. The backport applies cleanly. Langtools tier1...

/integrate

@TimvdLippe do you think the part about "using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, the compiler...

I'm going to make another release of Error Prone soon, and then will likely try updating the minimum supported version to JDK 21 for the next release after that.