Liam Miller-Cushon

This will be resolved once there's a new java_tools and rules_java release (https://github.com/bazelbuild/bazel/pull/22310)

I think I have worked around the windows-only failures I was seeing with ```diff executable_name = select({ - "@bazel_tools//src/conditions:windows": "%target%.exe", + "@bazel_tools//src/conditions:windows": "%target%", "//conditions:default": "%target%", }), ``` I think the...

Thanks for digging in to this! The approach 1 you described sounds fine to me too. For what it's worth I'm still slightly confused about where the duplicate `.exe` is...

> I suggest that you suppress the warning, with a reference to this issue. Done, thanks. I agree this is definitely low priority. It'd be nice if there ends up...

Thanks @smillst for taking a look! Here's one more example that seems closely related, where adding an explicit type argument doesn't seem to help: ```java import org.checkerframework.checker.nullness.qual.Nullable; class C {...

@hvadehra @meteorcloudy for Blaze we don't need to support log4j, so supporting this isn't a priority for me. I also don't want to stand in the way of progress if...

Sorry for the delay. Thanks for refactoring the combiner into a separate file, I'm fine with the current approach. (Internally we use a separate singlejar entry point with additional combiners,...

> Friendly ping @cushon I'm deferring to @hvadehra to review

I think the transition approach is more robust. Most of the shared dependencies are going to be the same, but I have seen examples of things like library code that...

I think the main downside in adding the attribute would be that it would be available to all users of `java_binary` and `java_test`, but it wouldn't work correctly for repos...