Liam Miller-Cushon

Results 378 comments of Liam Miller-Cushon

> There is currently no way to ensure these options are also passed at test or run time. Note that there's [`--jvmopt`](https://docs.bazel.build/versions/master/user-manual.html#flag--jvmopt) flag (and as of #11893) a corresponding `--host_jvmopt`...

Thanks for the report, I agree this is surprising. There are some heuristics for formatting Flogger-style fluent log statements, and usually everything up to `.log(` fits on a single line....

I think that's expected, there's a very special case for formatting of log methods: https://github.com/google/google-java-format/blob/8a0e3b3d7cb2c4efeffe5610aa1146a85f0ffa10/core/src/main/java/com/google/googlejavaformat/java/JavaInputAstVisitor.java#L1622

This is supported now: ``` $ java -jar google-java-format-1.32.0-all-deps.jar R.java class R { { int c = switch (r) { case Record(var a) -> a; case AnotherRecord(var b) -> b;...

Sorry for the delay here. I tried importing this, and ran into some issues with templates we have for cleanups related to https://github.com/google/truth. Truth deliberately declares overloads of `assertThat` in...

2.16 is an older version of Error Prone, I recommend upgrading to the latest version. This may be a dupe of https://github.com/google/error-prone/issues/4017. Are you using lombok?

Thanks for the report, this looks like the same stack trace as #4193 Is it possible to share a repro, or more information about the code it's crashing on? Where...

Sorry you had to figure this out the hard way, we should definitely document it somewhere. Maybe the wiki, perhaps in https://github.com/google/error-prone/wiki/For-Developers ? If you want to propose something I...

Thanks @msridhar! I added that to the wiki. Adjusting the versions constraints to be more compatible with `generate-jdk-toolchains-xml` also sounds like a good thing to consider.