rust icon indicating copy to clipboard operation
rust copied to clipboard

translation: doc comments with derives, subdiagnostic-less enum variants, more derive use

Open davidtwco opened this issue 1 year ago • 2 comments

  • Adds support for doc attributes in the diagnostic derives so that documentation comments don't result in the derive failing.
  • Adds support for enum variants in the subdiagnostic derive to not actually correspond to an addition to a diagnostic.
  • Made use of the derive in more places in the rustc_ast_lowering, rustc_ast_passes, rustc_lint, rustc_session, rustc_infer - taking advantage of recent additions like eager subdiagnostics, multispan suggestions, etc.

cc #100717

davidtwco avatar Oct 14 '22 12:10 davidtwco

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive avatar Oct 14 '22 12:10 rust-highfive

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

rustbot avatar Oct 14 '22 12:10 rustbot

Looks good.

@bors r+

compiler-errors avatar Oct 19 '22 02:10 compiler-errors

:pushpin: Commit 913f5974026334dbd2eeb4f39b0e4ea767e1b28d has been approved by compiler-errors

It is now in the queue for this repository.

bors avatar Oct 19 '22 02:10 bors