rust icon indicating copy to clipboard operation
rust copied to clipboard

Delay formatting trimmed path until lint/error is emitted

Open compiler-errors opened this issue 3 years ago β€’ 2 comments

Fixes #99387

r? @davidtwco

compiler-errors avatar Jul 29 '22 06:07 compiler-errors

@bors r=davidtwco

compiler-errors avatar Aug 05 '22 17:08 compiler-errors

:pushpin: Commit 694a010a5c5c77f8aef822d5a7b2f3abece1ad36 has been approved by davidtwco

It is now in the queue for this repository.

bors avatar Aug 05 '22 17:08 bors

:hourglass: Testing commit 694a010a5c5c77f8aef822d5a7b2f3abece1ad36 with merge 76b04847400effd127ced322d5627c0c1aec2998...

bors avatar Aug 06 '22 12:08 bors

:sunny: Test successful - checks-actions Approved by: davidtwco Pushing 76b04847400effd127ced322d5627c0c1aec2998 to master...

bors avatar Aug 06 '22 15:08 bors

Finished benchmarking commit (76b04847400effd127ced322d5627c0c1aec2998): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regression found
mean[^1] max count[^2]
Regressions 😿
(primary)
2.7% 2.7% 1
Regressions 😿
(secondary)
2.8% 2.8% 1
Improvements πŸŽ‰
(primary)
-4.4% -4.4% 1
Improvements πŸŽ‰
(secondary)
N/A N/A 0
All πŸ˜ΏπŸŽ‰ (primary) -0.8% -4.4% 2

Cycles

This benchmark run did not return any relevant results for this metric.

[^1]: the arithmetic mean of the percent change [^2]: number of relevant changes

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

rust-timer avatar Aug 06 '22 16:08 rust-timer