Michael Goulet
Michael Goulet
@rfcbot resolve four boxes Nope, no further concerns
Just needed a ping 😅
TBH I'm just gonna merge this now, given nobody except for the team probably cares what these criteria are, and that we've given this more than a year to sit.
> but R-A doesn't like it one bit yet so marking this as a draft PR. https://github.com/rust-lang/rust-analyzer/pull/16588
I didn't mention removing the move keyword--that is definitely needed.
I believe I addressed the comments, but please look closely because markdown is not my thing.
Well, except for: > Alternatively, it might be worth considering changing the implementation to reject 'r#xxx'yyy for consistency with the non-raw case. Which I think I will open a rustc...
@rustbot ready
LGTM!