Michael Goulet comments

Results 196 comments of


                                            Michael Goulet

pattern_analysis: Gracefully abort on type incompatibility

@bors r+

hir: Make sure all `HirId`s have corresponding HIR `Node`s

this is great! perf run just to check 🤷, but i'll honestly probably approve this even if there is a minimal perf hit @bors try @rust-timer queue

hir: Make sure all `HirId`s have corresponding HIR `Node`s

@bors r+

suggest `into_iter()` when `Iterator` method called on `impl IntoIterator`

r? compiler

suggest `into_iter()` when `Iterator` method called on `impl IntoIterator`

@bors r+ rollup

Add test for Apple's `-weak_framework` linker argument

@bors r+ rollup=iffy

Add test for Apple's `-weak_framework` linker argument

@bors r+

Update Windows platform support

Similarly to https://github.com/rust-lang/rust/pull/104385#issuecomment-1686512864, should this be a T-libs + T-compiler FCP, rather than T-compiler + T-release? I don't actually think we have a policy around bumping minimum support.

Update Windows platform support

Sure let's do an FCP. See MCP for details. @rfcbot fcp merge

Document `adt_const_params` feature in Unstable Book

r? @boxyuwu feel free to reassign to me tho