Michael Goulet comments

Results 300 comments of


                                            Michael Goulet

Suggest to use . instead of :: when accessing a method of an object

r? @compiler-errors

Suggest to use . instead of :: when accessing a method of an object

@chenyukang make sure to do: @rustbot ready When you're ready to review. Otherwise I might not see this, haha.

Suggest to use . instead of :: when accessing a method of an object

@bors r+

Obviously overlapping blanket impls are accepted

For the record, `:` is outlives syntax. See https://github.com/rust-lang/a-mir-formality/issues/147. I think the trait bound is expressed `Bar(T)`, though reference other tests to make sure.

Add the `#[diagnostic]` attribute namespace and the `#[diagnostic::on_unimplemented]` feature to the reference

This can/should get merged now

Don't allow try-builds to be rolled up

`state.status == 'pending' and not state.try_` should be `False` :'(

Format trailing where clauses in type aliases

@ytmimi: Yes, that formatting looks correct. When there is a where clause present, there's always a line break, then `=` and the type, then a break, then the where clauses.

Format trailing where clauses in type aliases

@calebcartwright @ytmimi: It's been almost a year since this PR was opened. Is there any chance we could finally get this merged? What's the plan on doing the next rustfmt->rust...

rustfmt stopped formatting `const` items in macros

This has to do with the weirdness of the way that `parse_macro_arg` works. Unlike parsing nonterminal args in a macro-by-example, it eagerly tries, for example, to parse a type without...

Move stability attribute section to std dev guide?

I *think* the only place we really use stability attributes are the standard library.