fmt-rfcs
fmt-rfcs copied to clipboard
Add team membership characteristics section
This is in service of the first item in our backlog
- Style team membership growth
Goals
- Clarify what it means to be a style team member and the paths to joining our team.
- Help new contributors get involved.
- Help existing team members review potential members and hold them to consistent and clearly communicated expectations.
Reviewed. Thank you for working on this, @yaahc!
Action item: We decided during the meeting August 30, 2023 that @yaahc will open an FCP on this when she's cleared Josh's final comments.
note to Jane: @ rfcbot fcp merge should work on this repo, but it'll take ~20 mins for the fcp to start since rfcbot scans all of the repos in the rust-lang org.
@rfcbot fcp merge
@rfcbot reviewed
Team member @yaahc has proposed to merge this. The next step is review by the rest of the tagged team members:
- [x] @calebcartwright
- [x] @compiler-errors
- [x] @joshtriplett
- [x] @yaahc
Concerns:
- ~~four boxes~~ resolved by https://github.com/rust-lang/style-team/pull/182#issuecomment-2107491803
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
@rfcbot concern four boxes
Have checked my box, should be all set now to have the concern resolved
@compiler-errors Any blockers to resolving the "four boxes" concern here? (Or, more to the point, any blockers to hitting "merge" here?)
@rfcbot resolve four boxes
Nope, no further concerns
Just needed a ping 😅
:bell: This is now entering its final comment period, as per the review above. :bell:
psst @yaahc, I wasn't able to add the final-comment-period label, please do so.
TBH I'm just gonna merge this now, given nobody except for the team probably cares what these criteria are, and that we've given this more than a year to sit.