Charles Kerr comments

Results 760 comments of


                                            Charles Kerr

refactor: remove unnecessary template type in EmitEvent()

Superseded by https://github.com/electron/electron/pull/48778, so closing this PR. > Is there a potential perf penalty in using the string_view converter for everything instead of theoretically using the char* converter which iirc...

[Bug]: Linux `defaultPath` does not work on file dialogs for opening

Just to check in with another datapoint, it seems to be working correctly for me on Ubuntu 24.04 x64. This is possibly specific either to 22.04 or the version or...

fix: apply default accelerator for role-based menu items

@Kimgun3383 re-ping :smile_cat:

fix: initialize keychain names early to ensure safeStorage uses correct app name

@felixrieseberg re-ping :smile_cat:

fix: menu bar hiding on two `setFullscreen(false)`

> So, @ckerr , do you think that this is the right approach? Have you considered whether this can break stuff? Because as I said, I have no idea what...

fix: menu bar hiding on two `setFullscreen(false)`

@WofWca could you rebase this on top of `main` to try & make CI happy? @jkleinsc does https://github.com/electron/electron/pull/45930/commits/48d1c64f3fffd879d767386db57e17a9b2423730 address your change request?

build: generate artifact attestions for released assets

@electron/wg-infra this PR's been in limbo for a couple of months now, does anyone have cycles to review?

feat: enable WASM trap handlers in all Node.js processes

> **Do Not Merge** > > Wait for verification from apps in #48956 Converting to a draft for now just to be safe

[Bug]:`showItemInFolder` does not open correct item location when run as Electron snap

Hey Craig, is this still an issue in newer versions of Electron, e.g. 19-x-y?

refactor: use WHATWG URL instead of `url.parse`

In general this PR is a Good Thing and I feel kinda bad that I've played a part in its staying in limbo for a month. @MarshallOfSound reping on https://github.com/electron/electron/pull/48674#discussion_r2466260230...