Charles Kerr

build: extract ninja cflags_cc from electron_app.ninja in spec runners

1

Discussed at https://github.com/electron/electron/blob/d67532ee9f836857bc43989fbb8376d1fe769a48/script/nan-spec-runner.js#L34-L53 but not implemented. Would have prevented the need for https://github.com/electron/electron/pull/33906/commits/41a03a5799a8f40f31555d73d20ea865acfcd192. Most importantly, cxxflags -std= and -nostdinc++ are needed. It's possible that the includes and isystem also need...

document the python 2 mac certificate issue

1

Leaving this as a breadcrumb so that I don't forget, because I don't have enough time to write it up properly right now. Reported this morning in #askanything: ```sh Hook...

equivalent to mp::import_bits, mp::export_bits?

1

More a question than an issue, but I was wondering if there are any plans for an import/export bit utility similar to mp::import_bits() and mp::export_bits()? From the 'Implementation goals' section...

### Pre-flight checklist - [X] I have read the [contribution documentation](https://github.com/electron-userland/electron-forge/blob/master/CONTRIBUTING.md) for this project. - [X] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses. - [X]...

v0.18.0 is a black screen on Windows after fresh install

6

I just installed v0.17.6 and v0.18.0 on a Windows VM. v0.17.6 works as expected, but v0.18.0 is just a menu + a black screen. New dialogs work, e.g. hitting "Open"...

bug: monaco themes are stored in wrong folder

3

[`CONFIG_PATH`](https://github.com/electron/fiddle/blob/master/src/renderer/constants.ts#L7) is hardcoded to be a .dotdir underneath the home directory, which ignores other conventions e.g. XDG_CONFIG_HOME.

Have an option to keep versions of Electron in zipped rather than unzipped form

2

Inspired by https://github.com/electron/fiddle/issues/638 and shares the same goal of saving disk space, but they're two different ideas that could both be implemented. A zipped Electron release is about 40% the...

bug: sometimes electron fiddle freezes when starting a fiddle

1

Not "frozen" in the total sense -- more, Electron Fiddle is still responding to user input, and _says_ the Fiddle is running, but nothing happens. I'm not sure if it's...

idea: unify Version and RunnableVersion into a class with lazy-getters for semver and state

1

Both @codebytere and I have done a lot of rewriting over the best way to handle passing Versions around efficiently, since we inevitably wind up parsing and reparsing the version...

draft version: ```diff diff --git a/src/renderer/task-runner.ts b/src/renderer/task-runner.ts index b705834..4b6bbe0 100644 --- a/src/renderer/task-runner.ts +++ b/src/renderer/task-runner.ts @@ -14,6 +14,7 @@ import { AppState } from './state'; import { getVersionRange } from '../utils/get-version-range';...