Charles Kerr

Results 760 comments of Charles Kerr

IIRC there is also an issue with downloading empty files in Transmission but I haven't come across one in ages. @Coeur DYK if this works / doesn't work?

I haven't thought this through or tested so this opinion might be wrong: ~~Adding the files in `recheck_completeness()` or a new `tr_torrent::create_empty_files()` seems brittle and error-prone to me.~~ (edited because...

> But then you're "requesting" those files to your peers, when you could be "seeding" them directly instead. inout.cc doesn't know anything about requests; it just reads or writes files...

@Coeur it looks like this PR is ready, but I just wanted to ask first because I'm not 100% sure how this plays with the other 0-byte file changes e.g....

These CI runs are failing in a consistent manner that doesn't seem to be related to this PR: ``` 2025-11-26T16:06:15.7430071Z cat: sas-token: No such file or directory 2025-11-26T16:06:15.7445538Z SAS Token...

> > I don't follow. What makes you think #7090 would help with this? > > With more and better automation in place using Github actions, the devs could have...

> > How? > > By saving you and other maintainers time? The more relevant Github automation you put in place, the easier it it to roll out future releases....

There doesn't seem to be consensus on this feature. TBH I'm in the camp of "the less PII exposed, the better" and am inclined to turn down this feature because...

I'm open to another solution to this, but my opinion about this approach is mostly unchanged since last December -- I still feel that exposing more PII is a step...

That is a much more interesting question than I'd expected it to be :smile_cat: Gonna mark this PR as a draft and do a little more reading