Charles Kerr

Results 705 comments of Charles Kerr

Good point. I should've been clearer & said that the popup in the GTK client is modal so that the rest of the client's UI is inaccessible.

@GaryElshaw agreed, 4759 is another possible cause. @Jerry23011 if macOS generates a hang report, could you attach it to this ticket?

> As long as the new interface is consistent about casing (and the "standard" one has the benefit of being consistent in other areas too, like error reporting) I can...

@mikedld can you re-review? You've still got this PR marked as Changes Requested :)

``` 2024-09-04T11:15:31.4103310Z ../../electron/shell/browser/native_window_mac.mm:1775:17: error: no member named 'add_child_window' in 'electron::NativeWindow' 2024-09-04T11:15:31.4104580Z 1775 | new_parent->add_child_window(this); 2024-09-04T11:15:31.4106720Z | ~~~~~~~~~~ ^ 2024-09-04T11:15:31.4107070Z 1 error generated. 2024-09-04T11:15:31.4107740Z ninja: build stopped: subcommand failed. ```