Charles Kerr

Results 646 comments of Charles Kerr

It doesn't always reproduce, but I am seeing this bug in both 19.0.8 and 19.0.0. I'm not able to trigger it in 19.0.0-alpha.1 though. I'll see if I can bisect...

Looks like it broke between 19.0.0.alpha-3 and -4

I'm not sure how to proceed with this ticket: The original scope was to sync cflags between the Electron build and the specs. _In that situation_ where we know the...

@MarshallOfSound are you still requesting changes on this PR? I don't feel strongly about it one way or the other, but don't want to leave it in limbo. We should...

I think I might be misunderstanding the problem. Might be that I have a disconnect because I've only ever installed build-tools from git, rather than from npm. If someone installs...

At the risk of piling on, I'd also like to see CMake support for libdeflate. It would make embedding it in my own CMake-based application much simpler. :)

@ckormanyos yep that would be perfect.

Fixed by https://github.com/electron/fiddle/pull/594

...wait, only partially fixed. #594 solves the issue for fiddle templates, but _not_ for the show-me samples.

FWIW when I install `electron-fiddle_0.12.0_amd64.deb` and try running electron 7.1.4, it works for me on Ubuntu 19.10. I tried both with and without an `~/.config/Electron` directory and it worked both...