Laurent Charignon

Results 35 comments of Laurent Charignon

That may cause the issue indeed, can you try with all the scopes, just in case? I cannot repro on emacs 27.1

This is concerning and I am investigating it now. I tried a couple of different machines on 27.1 and I am not able to reproduce with the latest code on...

I also tried the latest doom emacs and cannot repro. Sadly the deferred callback mechanism makes it hard to test, I believe that the issue is happening after you hear...

That's a great suggestion and I was planning to work on that + the ability to respond to inline comments. I will be taking a look in the coming weeks.

I started working on a solution (https://github.com/charignon/github-review/pull/10) @parhamdoustdar you can take a look and give feedback if interested.

I will merge #10 after cleaning up the code and fixing bugs and implement comments on code lines in another PR.

Are you sure you are talking about top level comments? (that is comments on the PR body and not the code). If you don't see comments made on code, that...

Thanks for your work, this is a nice simplification! I left one comment inline for you to take a look at. At this point the whole stack is fairly outdated...

To investigate this, I would start looking at patch support in magit and see if we can find a minor mode that would give us that kind of capabilities (folding...

Tested end to end on https://github.com/charignon/github-review/commit/0581a6079ebc1404c873aef133ee66d8bb7217c8