Generalized most of the pairs of -pr- and -commit- prefixed methods

[andrelkin]

that intended to work on the pr and commit document respectively into common methods. The type of the document is deduced from the document descriptor alist.

Fixed read-only buffer case that can turn in due to automatic diff-mode on .diff extension.

Extended github-review-save-diff with github-review-save-commit-id-in-buffer branch to controls whether to add the commit and its parent id info to the buffer as persistent buffer-locals.

[charignon]

Thanks for your work, this is a nice simplification! I left one comment inline for you to take a look at. At this point the whole stack is fairly outdated with master (alist operation + graphql API). I am planning to rebase it and update it.

[andrelkin]

Thanks for your work, this is a nice simplification! I left one comment inline for you to take a look at. At this point the whole stack is fairly outdated with master (alist operation + graphql API). I am planning to rebase it and update it.

Thank you, Laurent! When we'll make it through, I already have another feature request in progress, to share with you hopefully sooner :-)

[andrelkin]

@charignon, howdy. After a break caused by my load at workplace, I am resuming with this request. I see the PR has not been merged with master, perhaps not having me around to nag for that :-)?

I am trying to rebase on the up-to-date master but that's not really easy. To ease it I went to rebase first lc--mvp-review-commit, which I won't be able to complete today and then it would wait for next time slot hopefully on the next weekend. So I'm going to give it more efforts, but if your time permits perhaps you could beat me to that, and with quality :-)

Cheers,

Andrei

[andrelkin]

@charignon, resuming on my Apr 5 target, having time to understand how to make it the right way (git merge is not). Hope that is not interleaves with your generous merging plan (in which case just tell me to step away).