github-review icon indicating copy to clipboard operation
github-review copied to clipboard

PR changed files list & clickable filenames

Open rakanalh opened this issue 6 years ago • 2 comments

It would be great if the package can also show the list of files that have been changed. Also the file names / hunks should be clickable to be able to navigate to the file's place of change quickly.

Edit: This is similar to what magit offers

rakanalh avatar Feb 20 '19 11:02 rakanalh

To investigate this, I would start looking at patch support in magit and see if we can find a minor mode that would give us that kind of capabilities (folding a diff and navigate through it quickly):

  • If such feature exists we can it enable in the case where the PR belongs to a repo checked out locally already (see https://github.com/charignon/greview/issues/1)
  • If it does not exist, I would look at adding it to the magit mode for patches and leverage it here.

charignon avatar Feb 23 '19 02:02 charignon

Also it'll be great if the diff of hunks and files can be toggle between expanded and collapsed

yqrashawn avatar Sep 07 '21 01:09 yqrashawn