Laurent Charignon

Results 35 comments of Laurent Charignon

What do you mean by does not pick up? When you call `github-review-start` and give a link to a commit like `https://github.com/charignon/github-review/commit/0581a6079ebc1404c873aef133ee66d8bb7217c8` does it not work? What do your commits...

Your patch looks good, I added it and I will rewrite the author's name to match your name and email. I also added support for urls referring to commit in...

@andrelkin could you please take another look? Thanks

We can work on expanding it, we would have to rename the package though. Is that work you are interested in doing @yisraeldov ? Are you comfortable sending PRs for...

If someone wants to tackle this, you probably want to do: **1) Create and test support for the following gitlab APIs** - Get MR -> get the comments and summary...

@yisraeldov I am going to take that on in the coming weeks and will update this issue accordingly.

I just looked into it. It seems that everything is straightforward to implement with two caveats: 1) submitting a comment (called notes in Gitlab's verbiage) on a specific line of...

Unfortunately, that's the expected behavior for now, only top level comments are displayed, see #5. Contributions are welcome to add this feature.

It comes down to being able to have syntax highlighting in diff mode, I cannot find an example of someone who made that work, would be worth asking on r/emacs...

Thanks for the suggestion, it would be a great feature to add and I definitely miss not having that in `github-review` It would be a lot easier after the mode...