View Existing Comments on Code lines

[parhamdoustdar]

First of all, thank you a lot for this package. The Github code review interface sucks when using a screen reader, but this allows me to use it with Emacs and Emacspeak. Awesomeness!

One problem right now is that I don't see existing comments as I'm reviewing the code. It'd be great to see the existing comments as i'm reading.

[charignon]

That's a great suggestion and I was planning to work on that + the ability to respond to inline comments. I will be taking a look in the coming weeks.

[charignon]

I started working on a solution (https://github.com/charignon/github-review/pull/10) @parhamdoustdar you can take a look and give feedback if interested.

[charignon]

I will merge #10 after cleaning up the code and fixing bugs and implement comments on code lines in another PR.

[subsetpark]

Hi @charignon - it looks like this feature is not working for me. I havethe feature flag set to t but comments are not loaded. No messages in the buffer. Anything I can do to debug?

[charignon]

Are you sure you are talking about top level comments? (that is comments on the PR body and not the code). If you don't see comments made on code, that is the expected behavior as this is not yet implemented.

[codygman]

here is the query to get the nested review comments and code:

 {
  repository(name: "devos", owner: "codygman") {
    pullRequest(number: 1) {
      reviews(first: 50) {
        nodes {
          author {
            login
          }
          state
          comments(first: 50) {
            nodes {
              bodyText
              diffHunk
              originalPosition
            }
          }
        }
      }
    }
  }
}

But maybe we could use position or something to put the comment in the right place in the diff? I'm new to the graphql api.

You'd probably need to build everything differently with github-review-parse-line and any formatting functions, right?

[wandersoncferreira]

Just as a notification, this feature is now in master behind a feature flag. Would be very nice to have user feedbacks, please set github-review-view-comments-in-code-lines to t and let us know :)