Cameron Thornton
Cameron Thornton
@bskaplan apologies, but could you rebase your branch on recent `main`? CI changes were made that need to be included.
> > @c2thorn @hao-nan-li any idea what's up with `TestAccDefaultUniverseDomain_doesNotMatchExplicit`? > > Looking at the error message, seems like it's failing with the right error, but not quite the same...
I think the error we are getting is correct, and the test is wrong. I'm going to update in a separate PR. @hao-nan-li @rileykarson
We can keep it open and move it to the eventual major release branch when it gets closer to time?
Seems the tests are failing with diffs on the access field. Did they succeed locally?
Do we want a provider-wide changelog note?
> > Do we want a provider-wide changelog note? > > added We are expecting some user-facing impact right? Specifically user's facing https://github.com/hashicorp/terraform-provider-google/issues/6782 will now have their ipv4 settings honored?
Don't see any other changes necessary, so I'm going to go ahead and commit my small suggestion to move things along.