magic-modules
magic-modules copied to clipboard
Support service-level min instances in Cloud Run v2 services.
Support new Cloud Run feature service-level min instances in Cloud Run v2 Services.
Release Note Template for Downstream PRs (will be copied)
cloudrunv2: Support scaling.min_instance_count in Service.
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
/gcbrun
@bskaplan apologies, but could you rebase your branch on recent main
? CI changes were made that need to be included.
It's rebased
/gcbrun
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 1 file changed, 11 insertions(+)) Terraform Beta: Diff ( 3 files changed, 192 insertions(+)) TF Conversion: Diff ( 1 file changed, 29 insertions(+))
Tests analytics
Total tests: 37
Passed tests: 36
Skipped tests: 0
Affected tests: 1
Click here to see the affected service packages
- cloudrunv2
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCloudRunV2Service_cloudrunv2ServiceWithServiceMinInstances
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunV2Service_cloudrunv2ServiceWithServiceMinInstances
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test