Cameron Thornton
Cameron Thornton
> The additional complication is that, actually there is already a PUT call that can be used to update all the other fields (except for this nodeConfig) of this resource...
> Thanks, I added `update_verb` and `update_url` to the field, and generated a local provider. It seems that a code block that starts with `if d.HasChange("node_config") {` is generated here...
@xuchenma I took a look at this. What I didn't realize is that any PUT body needs to have the `nodeConfig` field present because the lack of `nodeConfig` apparently implies...
example an `update_encoder` https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/update_encoder/pubsub_topic.erb reference to the file in `terraform.yaml`: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/products/pubsub/terraform.yaml#L74
I believe the logic within the update encoder file will look like ``` old, _ = d.GetChange("node_config") obj["nodeConfig"] = old return obj, nil ```
@xuchenma I see, sorry for not catching that in your earlier message. we are really trying to stretch the MMv1 template with this logic here, and I am getting close...
Hi @xuchenma, I have spoken with Riley and he is also open to moving this to a handwritten resource if needed. To be frank, I cannot be 100% confident that...
> > I think we should go for handwritten resource when we need to support PUT updates to ApigeeEnvironment for new fields, but right now we can just set the...
Hi @rlv2022, not sure if this is still a relevant change. MM no longer supports CGC samples. I believe the "terraform-on-cgc" internal documentation has just been updated with the new...
Just dropping a comment to re-request my review whenever this is ready. That way it'll show up in my inbox again