magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Added CloudQuotas service and Create QuotaInfo Datasource

Open lola98 opened this issue 11 months ago • 1 comments

Add new datasource google_cloud_quotas_quota_info to provide information about a particular quota for a given project, folder or organization.

Release Note Template for Downstream PRs (will be copied)

google_cloud_quotas_quota_info

lola98 avatar Feb 27 '24 23:02 lola98

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Feb 28 '24 00:02 github-actions[bot]

Hi @rileykarson, could you help review the PR when you get a chance? Thanks!

lola98 avatar Mar 06 '24 00:03 lola98

/gcbrun

rileykarson avatar Mar 07 '24 19:03 rileykarson

Tests analytics

Total tests: 3496 Passed tests: 3140 Skipped tests: 354 Affected tests: 2

Click here to see the affected service packages
all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleQuotaInfo_basic|TestAccDefaultUniverseDomain_doesNotMatchExplicit

Get to know how VCR tests work

modular-magician avatar Mar 07 '24 20:03 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDataSourceGoogleQuotaInfo_basic[Error message] [Debug log] TestAccDefaultUniverseDomain_doesNotMatchExplicit[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 07 '24 20:03 modular-magician

@c2thorn @hao-nan-li any idea what's up with TestAccDefaultUniverseDomain_doesNotMatchExplicit?

rileykarson avatar Mar 07 '24 21:03 rileykarson

@c2thorn @hao-nan-li any idea what's up with TestAccDefaultUniverseDomain_doesNotMatchExplicit?

Looking at the error message, seems like it's failing with the right error, but not quite the same wording as expected here: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/provider/universe/universe_domain_compute_test.go#L60 . I did see other PRs having this test failing occasionally, a re-run could make it pass.

hao-nan-li avatar Mar 07 '24 21:03 hao-nan-li

@c2thorn @hao-nan-li any idea what's up with TestAccDefaultUniverseDomain_doesNotMatchExplicit?

Looking at the error message, seems like it's failing with the right error, but not quite the same wording as expected here: main/mmv1/third_party/terraform/provider/universe/universe_domain_compute_test.go#L60 . I did see other PRs having this test failing occasionally, a re-run could make it pass.

The error we're getting is flipping between the error for having no universe_domain in the credentials and the error for having a mismatching universe_domain in the credentials: https://github.com/hashicorp/terraform-provider-google/blob/main/google/provider/universe/universe_domain_compute_test.go#L53

Not sure why the value would change in our environment. The test or environment should probably be updated.

c2thorn avatar Mar 07 '24 22:03 c2thorn

I think the error we are getting is correct, and the test is wrong. I'm going to update in a separate PR. @hao-nan-li @rileykarson

c2thorn avatar Mar 07 '24 22:03 c2thorn

/gcbrun

rileykarson avatar Mar 08 '24 20:03 rileykarson

Tests analytics

Total tests: 3498 Passed tests: 3144 Skipped tests: 354 Affected tests: 0

Click here to see the affected service packages
all service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

modular-magician avatar Mar 08 '24 21:03 modular-magician

/gcbrun

rileykarson avatar Mar 12 '24 21:03 rileykarson

/gcbrun

rileykarson avatar Mar 12 '24 22:03 rileykarson

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 421 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 10 files changed, 408 insertions(+))

modular-magician avatar Mar 12 '24 22:03 modular-magician

Tests analytics

Total tests: 3513 Passed tests: 3154 Skipped tests: 357 Affected tests: 2

Click here to see the affected service packages
all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

modular-magician avatar Mar 12 '24 23:03 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log] TestAccProjectIamPolicy_invalidMembers[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Mar 12 '24 23:03 modular-magician