magic-modules
magic-modules copied to clipboard
Add support for AuthorizedView resource in Bigtable
Release Note Template for Downstream PRs (will be copied)
`google_bigtable_authorized_view`
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 4 files changed, 1321 insertions(+))
google-beta
provider: Diff ( 4 files changed, 1321 insertions(+))
Errors
google
provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
google-beta
provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
Tests analytics
Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0
Click here to see the affected service packages
- bigtable
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$ View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 4 files changed, 1302 insertions(+))
google-beta
provider: Diff ( 4 files changed, 1302 insertions(+))
Errors
google
provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
google-beta
provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
Tests analytics
Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0
Click here to see the affected service packages
- bigtable
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$ View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 4 files changed, 1303 insertions(+))
google-beta
provider: Diff ( 4 files changed, 1303 insertions(+))
Errors
google
provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
google-beta
provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
Tests analytics
Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0
Click here to see the affected service packages
- bigtable
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$ View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 5 files changed, 1265 insertions(+), 1 deletion(-))
google-beta
provider: Diff ( 5 files changed, 1265 insertions(+), 1 deletion(-))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_bigtable_authorized_view
(8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_bigtable_authorized_view" "primary" {
project = # value needed
}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 6 files changed, 1406 insertions(+), 101 deletions(-))
google-beta
provider: Diff ( 6 files changed, 1406 insertions(+), 101 deletions(-))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_bigtable_authorized_view
(8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_bigtable_authorized_view" "primary" {
project = # value needed
}
Tests analytics
Total tests: 3633
Passed tests: 3263
Skipped tests: 369
Affected tests: 1
Click here to see the affected service packages
all service packages are affected
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccHealthcareDatasetIamPolicy
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcareDatasetIamPolicy
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 7 files changed, 1568 insertions(+), 101 deletions(-))
google-beta
provider: Diff ( 7 files changed, 1568 insertions(+), 101 deletions(-))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_bigtable_authorized_view
(8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_bigtable_authorized_view" "primary" {
project = # value needed
}
Tests analytics
Total tests: 3633
Passed tests: 3264
Skipped tests: 369
Affected tests: 0
Click here to see the affected service packages
all service packages are affected
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log
Don't see any other changes necessary, so I'm going to go ahead and commit my small suggestion to move things along.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 7 files changed, 1570 insertions(+), 101 deletions(-))
google-beta
provider: Diff ( 7 files changed, 1570 insertions(+), 101 deletions(-))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_bigtable_authorized_view
(8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_bigtable_authorized_view" "primary" {
project = # value needed
}
Tests analytics
Total tests: 3633
Passed tests: 3264
Skipped tests: 369
Affected tests: 0
Click here to see the affected service packages
all service packages are affected
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log
Looks like another PR was merged that modified the go.mod.erb file. May have to rerun the dependency upgrade with go get <dependency>
Looks like another PR was merged that modified the go.mod.erb file. May have to rerun the dependency upgrade with
go get <dependency>
Done.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 7 files changed, 1483 insertions(+), 16 deletions(-))
google-beta
provider: Diff ( 7 files changed, 1483 insertions(+), 16 deletions(-))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_bigtable_authorized_view
(8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_bigtable_authorized_view" "primary" {
project = # value needed
}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 7 files changed, 1483 insertions(+), 16 deletions(-))
google-beta
provider: Diff ( 7 files changed, 1483 insertions(+), 16 deletions(-))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_bigtable_authorized_view
(8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_bigtable_authorized_view" "primary" {
project = # value needed
}
Tests analytics
Total tests: 3633
Passed tests: 3264
Skipped tests: 369
Affected tests: 0
Click here to see the affected service packages
all service packages are affected
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log
Tests analytics
Total tests: 3633
Passed tests: 3264
Skipped tests: 369
Affected tests: 0
Click here to see the affected service packages
all service packages are affected
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log