Jean Boussier
Jean Boussier
Yes absolutely. I'm using `LPOP` purely as an example here, not as the sole reason I want this. And this wouldn't even replace LMOVE because LMOVE gives even more guarantees...
> I feel a lot more comfortable with just erroring on idempotency failures in the database layer. To be clear, I totally see how saving the response can be challenging,...
> it's every monday at 14:00 UTC. It seems like you're in France, which makes it a pretty nice time for you :) That should work for me.
Relative gains on M3 compared to master on the macro benchmarks: ``` == Encoding activitypub.json (52595 bytes) ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin23] Warming up -------------------------------------- after 2.529k...
This one is interesting, as it doesn't require any of the annoying feature detection SIMD impose. But if we end up going with SIMD anyway, might as well not bother...
> It's nice to have a pure C implementation that doesn't require any special instructions. True. I guess my only real reservation with this PR (and also with the SIMD...
> I have not tested on any other than my M1 and Intel-based Laptop. It's likely enough. x86 alone is likely 95% of Ruby usage if not more, we're probably...
> It's not necessary. It's the existing conditional. I just didn't want to copy and paste it multiple times. Yes, I mean not having that big macro without copy-pasting either....
NB: I'm not asking you to do this. If you wish to feel free to, but otherwise I want to find some time to try it before I merge this...
Is this really worth it now that we merged SIMD code? I suspect not? I'll reopen if you think it does.