Jean Boussier
Jean Boussier
@joshuay03 I addressed your feedback.
Any news?
@dentarg I didn't know about this, but yes it could easily be included. The question as always being how to present it to the user.
I'm absolutely unfamiliar with this codebase, and unsure what this code does. But I'd suggest looking into various string APIs that allow you counting lines without allocating a string for...
Since there is now two PRs open, I see no reason to keep this open.
> There is one potential incompatibility with this: RTYPEDDATA_P will return true for all T_DATA. I think after this change, `RTYPEDDATA_P` has almost no more usefulness internally, so we can...
You should also be able to get rid of `RUBY_TYPED_FL_IS_TYPED_DATA`.
> I guess that function returns a BINARY string Yep. It's not used much, except for Rack because the spec says string should be BINARY in quite a few places.
> you can just install it and somewhere in your app initialization run `ChildSubreaper.enable` I haven't looked at this PR diff, but for the record that gem was initially intended...