Jean Boussier

Kind of, the crux of the problem is that the spec says thread local state (including current attributes etc) must be copied: https://github.com/rails/rails/blob/4256e620570bf1dc86a597618065ec18a1efa9df/actionpack/test/controller/live_stream_test.rb#L528-L571 This is so that whatever state your...

There's nothing `AC::Live` specific in your repro, the controller is entirely bypassing Active Record, creating raw PG connections and spawning threads: https://github.com/jonbarlo/action-controller-segmentation-fault-error/blob/fa2f8a5a6dd69fa639e3ab424beb17c1997af545/rails-test-app/app/controllers/test_controller.rb It is known that using the same connection...

The warning isn't really from `open-uri` but from passing a literal to a method that mutate the argument. The fix is to do: `OpenURI::Meta.init(o = ''.dup)`

An easy way to solve these warnings is to run ruby with `--enable-frozen-string-literal --debug-frozen-string-literal`, this will include the location where the string was allocated in the FrozenError message.

I recommend you add one Ruby with `--enable-frozen-string-literal --debug-frozen-string-literal` in the CI Matrix. Also I silenced those warnings when I revamped CI, it should now be removed.

> Can you clarify what you mean by one service using this new API? By that I mean changing S3 or CGS to start using something else than MD5 to...

> I am concerned that adding functionality to have the services use something other than MD5 and storing with the prefix is going to add over 500+ lines to this...

> why so passive aggressive? I don't think Dima is being aggressive in any way. He's just providing his technical opinion in a, perhaps terse, but honest way. That said,...

> I've renamed the `allowed_columns` to `permitted_columns` Why not just `columns`? Or `only_columns`? I don't have a very strong opinion, but `permitted` seem a bit weird to be. > I...

Sorry, as I warned, I've been busy lately. Let me have another look.