Jean Boussier

Results 529 comments of Jean Boussier

The gain seem to be 7% on real word benchmarks: ``` == Encoding activitypub.json (52595 bytes) ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin23] Warming up -------------------------------------- after 2.438k i/100ms...

Can you just include the implementation for the regular escaping? I'm not sure the script safe version is quite worth it.

Not sure why but it's way more modest on my machine (Air M3): ``` == Encoding activitypub.json (52595 bytes) ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin23] Warming up --------------------------------------...

> Apologies for going dark for a while That's no worries at all. I want to release a `2.10.0` with the current change on master, but I'm pairing with Étienne...

With that compilation flag and compared to `master`: ``` == Encoding activitypub.json (52595 bytes) ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin23] Warming up -------------------------------------- after 2.326k i/100ms Calculating -------------------------------------...

> What do you all think about that? ☝️ I think I like this PR architecture a bit better. That being said, to me the big decider for me is...

Also we should have a way to disable SIMD with a compile flag, so that all codepaths can be exercised on CI.

> There are no 64bit x86 CPUs without SSE2 Ah, interesting. I definitely expected most CPU made in the last 20 years to have it, but was worried some low-power...

> and/or make the SIMD code path opt-in instead of opt-out. Opt-out is fine, my only concern is the non-SIMD codepath being tested on CI. Because on GitHub Actions we...

> On Linux, at least, it looks like we must read from `/proc/cpuinfo` or `/proc/self/auxv`. As we discussed previously, we can probably assume NEON support is there. We'd only need...