Jean Boussier

Results 529 comments of Jean Boussier

@julik all your questions have been answered previously. As for the potential mis-usage, yes sure, this is programing there is always a millions ways to shoot yourself in the foot....

> Does Shopify has any interest in Puma? Most Shopify apps except the two biggest ones run on Puma. I don't think there is interest in Puma's `fork_worker` feature though,...

> the strongest speculative driver would be more efficient execution / lower latency from a warmed worker I concur, the memory saving was the initial reason behind Pitchfork (to allow...

Also I meant to comment on: > What I think is needed is long-term commitment from such organizations, not one-off contributions. I don't fully agree with this, the actual work...

> I guess this is not desirable for worker 0 and I wonder what I should do in this case There's just no good solution, I'm afraid, hence why forking...

> Right interface or not? Looks good to me. I'm just not 100% certain about the terminology? > I'm mostly concerned about what happens when someone screws this up Is...

> if you want to defer the request you'd call `env["puma.deferred_request"].call`? Well `request.env["puma.deferred_request"].call` but yes. > Not the prettiest code That's usually how rack interfaces work. I do plan to...

> how would Rails detect that it's supported by the running web server? Like other optional rack features. Just check if the key is present in the `env` hash.

I started some renaming and added a couple unit tests. I'm traveling today, so not sure how much more I'll be able to do, but it should already look a...

> We really should rename `@workers` in `ThreadPool` to `@processors` in a follow-up, it's confusing even in the current state. Agreed. But I wanted to minimize diff size for review...