Brent Shaffer comments

Results 407 comments of


                                            Brent Shaffer

Allow JWT::decode to accept an empty string as a valid kid

@ryanneufeld are you being serious?

Allow JWT::decode to accept an empty string as a valid kid

My concern is not that the spec forbids it, my concern is that this adds logic which is not defined by any spec. Supporting an empty string as a KID...

Allow JWT::decode to accept an empty string as a valid kid

See https://g.co/gemini/share/76e85b5fc2d8. The two main concerns which I also share are ``` Ambiguity and Collision: An empty string kid means multiple JWKs could theoretically have the same identifier. This makes...

[1.34.1] Maximum call stack size of 8339456 bytes (zend.max_allowed_stack_size - zend.reserved_stack_size) reached. Infinite recursion?

@krystianlaubach I've posted the issue to the `grpc` repo here: https://github.com/grpc/grpc/issues/39509 Will try to take a look. In the meantime, has anyone tried this with the latest gRPC version (at...

[1.34.1] Maximum call stack size of 8339456 bytes (zend.max_allowed_stack_size - zend.reserved_stack_size) reached. Infinite recursion?

> I found the solution Friends!!!!!!!! (google ads php) > you need add "->withTransport('rest') " This is not a solution, but a workaround. You're using REST instead of gRPC. There's...

Bigtable: race condition in resuming ReadRows can lead to unintentional full table scan

Thanks for reporting this @igorbernstein2! No RPCs are made in the block you've linked to, so I'm not sure that is where a race condition would take place. If I...

Bigtable: race condition in resuming ReadRows can lead to unintentional full table scan

> the retry logic will craft a retry request that will exclude ranges that can been consume Maybe this is what I don't understand. If the values in `$rowSet` or...

Bump google-auth dep version

thank you @razvanphp ! Is there a specific reason why this needs to be bumped? I'm happy to do it, but I am curious because we do have `--prefer-lowest` tests...

Bump google-auth dep version

closing because it's too difficult to get these tests to pass from a fork and with a non-google author, and since I updated the PR from main, now it requires...

[PubSub] Phpdoc for PubSubClient's constructor is incorrect

Thanks for reporting this! You're right, we forgot to update the PHPDoc