google-api-php-client icon indicating copy to clipboard operation
google-api-php-client copied to clipboard

Bump google-auth dep version

Open razvanphp opened this issue 1 year ago • 2 comments

https://github.com/googleapis/google-auth-library-php/pull/566

razvanphp avatar Sep 03 '24 07:09 razvanphp

thank you @razvanphp !

Is there a specific reason why this needs to be bumped? I'm happy to do it, but I am curious because we do have --prefer-lowest tests which are passing, so if there's a compatibility error with a previous version, I would like to check why we aren't catching it.

bshaffer avatar Dec 16 '24 22:12 bshaffer

Ah, I see your point. The reason is so that we can use the features included in those new versions without risking not having them.

We have a dependancy on this repo only, not on the auth package. Maybe we can add this as explicit in our composer.json instead?

razvanphp avatar Jan 20 '25 19:01 razvanphp

closing because it's too difficult to get these tests to pass from a fork and with a non-google author, and since I updated the PR from main, now it requires two authors, which is a huge hassle.

Also it's not a change we really need.

bshaffer avatar Sep 05 '25 22:09 bshaffer