Brent Shaffer comments

Results 407 comments of


                                            Brent Shaffer

feat: add support for $_ENV and $_SERVER in CredentialsLoader

@jannes-io hmm, now I'm thinking, is there any real reason we want to load from `_SERVER`? It seems to me that `_ENV` would be sufficient and preferable.

feat: add support for $_ENV and $_SERVER in CredentialsLoader

@jannes-io okay that's what I thought! Thanks for your quick reply. So it makes sense to WRITE to both (since SERVER also contains ENV), but I can't think of a...

feat: add support for $_ENV and $_SERVER in CredentialsLoader

@jannes-io released in [v1.47.0](https://github.com/googleapis/google-auth-library-php/releases/tag/v1.47.0). Thanks for your contribution!!

run/laravel tests not configured correctly

@glasnt this should be fixed in #1991 - I updated the script to hide the "No such file or directory" error output, and to check in both `test` and `tests`...

Add `JWT::resetTime()` && `JWT::maxLeeway()` to simplify unit tests

Thanks for your contribution! I don't generally like exposing functions like this which are 1) testing only and 2) already possible with roughly the same amount of code.

Allow a list of strings as header value in `JWT::encode()`

@herndlm unfortunately that isn't my call wrt the CLA But I'm confused what you're trying to accomplish with this PR. You're only changing the PHP doc, which already accepts an...

Allow a list of strings as header value in `JWT::encode()`

> the list is just slightly more strict and would enforce (when being checked by e.g. phpstan or psalm) an array with integer keys in ascending order without any gaps...

Update MyBusinessAccountManagement.php

these classes are autogenerated

Internal query iterator's batch size limit is undefined (Firestore Datastore)

Hi @calsmith Thank you for your question! The default to `resultLimit` is `0`, or no limit. This can be [seen here](https://github.com/googleapis/google-cloud-php/blob/cca8093de47b12b3973e62040d445e1491b5734b/Core/src/Iterator/PageIteratorTrait.php#L122). So the iterator will iterate until there are no...

Clarification or Solution for Atomic Operations Post batch() Deprecation

Assigning to @Hectorhammett who is working on Firestore V2 to assess this