[PubSub] Phpdoc for PubSubClient's constructor is incorrect

[taka-oyama]

I noticed that

https://github.com/googleapis/google-cloud-php/blob/4021aec302618a592dd095956e58925390ff3911/PubSub/src/PubSubClient.php#L146-L147

Doesn't work. It's suppose to be credentials.authCache. I think the same thing can be said for authCacheOptions.

I'm fairly certain keyFilePath doesn't work here either.

Please take a look. Thanks.

[taka-oyama]

I found a migration page that describes the changes. I guess someone forgot to update the phpdoc?

https://github.com/googleapis/google-cloud-php/commit/70e22653a8082edac82f3987b48a327dcc5f69b4#diff-7e7a3f0069164da412cef8834788fd94cabb3d11bdd2ee31cd996bd7e23fa5f7R17-R39

[bshaffer]

Thanks for reporting this! You're right, we forgot to update the PHPDoc