google-cloud-php icon indicating copy to clipboard operation
google-cloud-php copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

feat!: [Spanner] Upgrade to V2

Open ajupazhamayil opened this issue 10 months ago • 3 comments

Spanner V2:

Part 1:

  • [x] Replacing Connection object with RequestHandler [Operation class]
  • [x] Replacing Connection object with RequestHandler [Database class]
  • [x] Replacing Connection object with RequestHandler [Session class]
  • [x] Replacing Connection object with RequestHandler [CacheSessionPool class]
  • [x] Introduce LongRunningOperationsManager [Replacing Connection object with RequestHandler in Core's LongRunningOperation]

Part 2:

  • [x] Replacing Connection object with RequestHandler [Backup class]
  • [x] Replacing Connection object with RequestHandler [Instance class]
  • [x] Replacing Connection object with RequestHandler [InstanceConfiguration class]
  • [x] Replacing Connection object with RequestHandler [SpannerClient]
  • [x] Remove Connection Classes and Directory 🎉

Tests:

  • [x] System tests
  • [x] Unit tests
  • [x] Snippet tests
  • [x] System tests
  • [x] Unit tests
  • [x] Snippet tests

Related work:

  • [x] Migration.md file
  • [ ] Update Admin Clients to Use V2 OperationsClient [GAPIC generator change] [See @TODO in Spanner/src/Admin/Database/V1/Client/DatabaseAdminClient.php] : This is replaced with the migration status changes.

BREAKING_CHANGE_REASON=RC-1 for the version 2 of the Spanner library.

ajupazhamayil avatar Apr 01 '24 11:04 ajupazhamayil

I see this is in draft mode, but the design is confusing to me. Do you have a document or anything to describe this approach?

We did not create any design document for these changes. We are following a V2 parent doc drafted by @saranshdhingra. Basically we are trying to remove usage of connection class objects and replace the usage with RequestHandler

Please let me know if you would like me to create a doc for this purpose.

ajupazhamayil avatar Apr 15 '24 07:04 ajupazhamayil

The "Prefer Lowest" tests are failing because you've added a new Trait to google/cloud-core, you need to upgrade the minimum version of cloud core specified in Spanner/composer.json

bshaffer avatar Jun 12 '24 21:06 bshaffer

The "Prefer Lowest" tests are failing because you've added a new Trait to google/cloud-core, you need to upgrade the minimum version of cloud core specified in Spanner/composer.json

Great, the test is passing now..

ajupazhamayil avatar Jun 13 '24 07:06 ajupazhamayil