protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

[7392] fix conformance test in PHP JSON parser

Open antongrbin opened this issue 1 year ago • 4 comments

Motivation

This PR fixes failing JSON conformance tests for php with name IgnoreUnknownEnumStringValue*.

The JSON parsing spec was discussed in https://github.com/protocolbuffers/protobuf/issues/7392.

Recent similar changes in other languages:

  • Python: https://github.com/protocolbuffers/protobuf/commit/86abf35ef5ee5b1004ec11bebb36d84c2ef6645e
  • Swift: https://github.com/apple/swift-protobuf/pull/1345
  • C#: https://github.com/protocolbuffers/protobuf/pull/15758
  • C++: https://github.com/protocolbuffers/protobuf/pull/16479

antongrbin avatar May 04 '24 13:05 antongrbin

@jskeet, since you worked with me on the linked issue https://github.com/protocolbuffers/protobuf/issues/7392, is it OK to ask you to help me find a PHP reviewer to move this forward?

antongrbin avatar Jun 24 '24 18:06 antongrbin

@antongrbin I can take a look

bshaffer avatar Jun 24 '24 18:06 bshaffer

@bshaffer thank you for the review offer && polite ping :)

antongrbin avatar Jul 08 '24 12:07 antongrbin

@bshaffer friendly ping :)

antongrbin avatar Jul 23 '24 19:07 antongrbin