freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

ctags: Use C99 bool instead of defining our own

Open collinfunk opened this issue 1 year ago • 4 comments

Use stdbool.h definitions instead of defining non-standard ones.

collinfunk avatar Feb 07 '24 00:02 collinfunk

Two of the style(9) failures are from the weird GETC macro. The others are because I did not add previously missing parentheses around return values. Should I amend or leave it for a different patch?

collinfunk avatar Feb 07 '24 00:02 collinfunk

I'd match the existing style, so don't change the returns. The GETC stuff is a weird macro, and it's just a false positive, so it's good.

bsdimp avatar Feb 07 '24 02:02 bsdimp

I think this is ready. I'll try to land it later today.

bsdimp avatar Feb 07 '24 16:02 bsdimp

That should be all of them hopefully...

collinfunk avatar Feb 07 '24 21:02 collinfunk

Merged.

markjdb avatar Apr 19 '24 18:04 markjdb