freebsd-src Apply libxo to a part of nvmecontrol

@bsdimp

May 24 '25 01:05 kenrap

Thank you for taking the time to contribute to FreeBSD! There is an issue that needs to be fixed:

Missing Signed-off-by lines^{1bf9dcb4336e95e4c052b50522dbe8ec749e5195, 49da81b0e28ab27aa95ae35a1cf2fc58b772c664, 862012c31c0de8de66841252c34dcd3688f60553, 2c50233275ee793dd1e02c9c5e94ebfed2ab6447}

May 24 '25 01:05 github-actions[bot]

Does this need an update to nvmecontrol(8)? If so, I can help!

Jul 07 '25 22:07 concussious

I'm not sure. The changes here just give it the ability to change outputs for different uses.

Jul 08 '25 00:07 kenrap

So the user facing behavior will change?

Jul 08 '25 20:07 concussious

We'd need do document --libxo command line argument. Generally, we don't document the schema used, but maybe we should start. I don't want to gate this commit, though, on that.

Jul 08 '25 23:07 bsdimp

appplogies for the delay. Do you get any warnings with --libxo:XPW or --libxo:JPW?

Jul 24 '25 21:07 bsdimp

It doesn't recognize both as options for the logpage and devlist commands... 😅

Jul 24 '25 22:07 kenrap

So, I didn't do all of nvmecontrol because it would be a huge diff count and didn't want to create extra review work. I could spend time getting all of nvmecontrol libxo-ified, but imagining the diff count being at least in the 4 digits was what made me submit this work much earlier.

Jul 24 '25 22:07 kenrap