Brian Kennedy

confusing error message "File is not goimports-ed (goimports)"

29

A file not being "goimports-ed" is a little confusing. Can we adjust this error message to something a little clearer like "File has not been formatted (goimports)"

If someone puts a default value in the OpenAPISpec for a ConstraintTemplate, this results in an error. The ConstraintFramework should handle populating the default if present.

ParentReference.Namespace has unnecessary pointer to string.

15

https://github.com/kubernetes-sigs/gateway-api/blob/master/apis/v1beta1/shared_types.go#L48 > "Namespace is the namespace of the referent. When unspecified (or empty string), this refers to the local namespace of the Route." Given that the zero value in Go...

Print out existing conditions on conformance test failure

3

**What would you like to be added**: Conformance tests validate conditions which are set on Gateway, HTTPRoute, etc. On test failure, the test prints out that the wanted condition was...

Add make rule for running goimports

2

**What happened**: Running `make fmt` does not address linter formatting concerns. **What you expected to happen**: There should be a `make fmt` or `make goimports` rule that brings files to...

**What would you like to be added**: Improve logging for conformance test conditions to include the "got" in addition to the "want". In particular, `HTTPRouteInvalidCrossNamespaceParentRef/Gateway_should_have_0_Routes_attached` needs improvement. **Why this is...

Rest client has global backoff setting with no per-client option.

1

The rest client uses environment variables for configuring the backoff manager for retries on GET requests which error out due to connection reset. This should be configurable per client instance....

Rest Client defaults to no backoff

1

The rest client defaults to no backoff when a custom one is not defined in any environment variables. This seems dangerous since GET requests which error out due to connection...

**What would you like to be added**: Expose configuring [CustomDialContext](https://github.com/kubernetes-sigs/gateway-api/blob/8345de3bf75a472978ea5c595165f9673ffcdaac/conformance/utils/roundtripper/roundtripper.go#L111) through [ConformanceOptions](https://github.com/kubernetes-sigs/gateway-api/blob/8345de3bf75a472978ea5c595165f9673ffcdaac/conformance/utils/suite/suite.go#L120). **Why this is needed**: The `DefaultRoundTripper` contains some [logic for TLS client config](https://github.com/kubernetes-sigs/gateway-api/blob/8345de3bf75a472978ea5c595165f9673ffcdaac/conformance/utils/roundtripper/roundtripper.go#L127). As time goes on, it...

**What happened**: I noticed that [MakeRequestAndExpectEventuallyConsistentResponse](https://github.com/kubernetes-sigs/gateway-api/blob/400e36da6929b98674e1d71bdd7eb65ca72e7438/conformance/utils/http/http.go#L104) hard codes the `http` scheme. **What you expected to happen**: The scheme and should be derived from `ExpectedResponse.Request.Protocol`.