Add make rule for running goimports

[briantkennedy]

What happened:

Running make fmt does not address linter formatting concerns.

What you expected to happen:

There should be a make fmt or make goimports rule that brings files to a state where hack/verify-golint.sh will pass.

How to reproduce it (as minimally and precisely as possible):

Alter line spacing on imports then run make fmt; make verify.

[akankshakumari393]

Hey @briantkennedy, I couldn't reproduce the issue, I added line spaces on imports in the file cmd/admission/main.go like this

import (
	"context"
	"crypto/tls"
	"errors"

	"flag"
	"fmt"
	"net/http"
	"os"
	"os/signal"
	"sync"

	"syscall"

then after running make verify hack/verify-golint.sh script passed. Could you please add more details on what is missing here.

[akankshakumari393]

/assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[shaneutt]

@akankshakumari393 it's been a while since we heard back from you on this one, are you still interested in this one? Do you need any help moving it forward?

[akankshakumari393]

I might not be able to work on the issue, feel free to reassign it.👍

[shaneutt]

Ok thanks for the heads up!

[shaneutt]

This has been open for a long time without someone to push it through, given that it's such a minor thing and nobody seems to be clamoring for it (I get the sense that this might not be a problem for most people) we're going to close this for now as it doesn't seem to have any priority. If this is something you want, and you're up for working on it let us know it's no problem to re-open!