Brian Kennedy

Results 8 comments of Brian Kennedy

@robscott does this mean conformance tests should expect an error if a user provides `namespace: ""` for this field? The docstring for the API explictly says `When unspecified (or empty...

So if we want to handle `nil` and `""` as equivalent, why not have a `string` with `"omitempty"` behavior instead of the `*string` and reduce the number of cases that...

Actually, taking a step back from my previous comment, I think our conversation is going something like this: @briantkennedy : Our docs say nil / "" do the same thing,...

So, to back up a bit, what's the behavior we want for this field when given empty string? It sounds like you're both saying the API should treat empty string...

So, the docstring for this field currently specifies that empty string is a valid value (eg `namespace: ""`). > Namespace is the namespace of the referent. When unspecified (or empty...

Is this issue referring to [meta.Key](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/5e23f913df1b9700a40c64c57258d7e91c9c240a/pkg/cloud/meta/key.go#L25) or has `meta.KeyType` been removed?