gateway-api
gateway-api copied to clipboard
kubernetes-sigs
Print out existing conditions on conformance test failure
What would you like to be added:
Conformance tests validate conditions which are set on Gateway, HTTPRoute, etc. On test failure, the test prints out that the wanted condition was not found, but it does not print out the conditions which were present. Please add functionality to print out the conditions which were present when the test failed.
Why this is needed:
This will help improve the experience of debugging conformance test failures.
@robscott: This request has been marked as suitable for new contributors.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
/area conformance /good-first-issue
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I think this has been resolved with the changes in #1363 and #1367, thanks @abhijit-dev82!
/close
@mikemorris: Closing this issue.
In response to this:
I think this has been resolved with the changes in #1363 and #1367, thanks @abhijit-dev82!
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.