Brian Low

Results 49 comments of Brian Low

Thanks @iskandr. Any chance you can post a compilable model?

I have a failing test but can't crack this one. Not sure how to determine which input layer to include (currently it is trying to include both). Does the the...

I am reviewing this PR. Please don't close. This is great work, thank you @duese. My apologies for not being able to review sooner.

@josefadamcik (Sofle), @DaneEvans (Sofle RGB), @winder (Sofle Keyhive) for visibility

@drashna thank you for the review and detailed comments. Applied all of them to this PR. Ready for review again

> Does this version still have the bug where the slave half doesn't synch RGB state from master? Fixed thanks to @derpus-potatus and @at669

@B-1P details here: https://github.com/josefadamcik/SofleKeyboard/issues/124#issuecomment-1025069293

Thanks @fauxpark, moved new keymaps under choc: ``` keyboards/sofle/choc/keymaps/default keyboards/sofle/choc/keymaps/via ```

An eslint check on CI requires the cli + plugin + authentication credentials because of the postinstall step in package.json: ``` "postinstall": "flex-plugin pre-script-check" ``` Ideally, in my mind, package.json...