qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Published 20 hours ago • verified publisher icon qmk

Sofle Choc hardware variant

Open brianlow opened this issue 2 years ago • 11 comments

Description

  • New hardware variant of the Sofle keyboard (keyboards/sofle/choc)
  • New default keymap (keyboards/sofle/keymaps/choc_default)
  • New Via keymap (keyboards/sofle/keymaps/choc_via)

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

brianlow avatar Mar 27 '22 00:03 brianlow

@drashna thank you for the review and detailed comments. Applied all of them to this PR. Ready for review again

brianlow avatar Mar 27 '22 05:03 brianlow

Does this version still have the bug where the slave half doesn't synch RGB state from master?

B-1P avatar Mar 29 '22 06:03 B-1P

Does this version still have the bug where the slave half doesn't synch RGB state from master?

Fixed thanks to @derpus-potatus and @at669

brianlow avatar Mar 29 '22 06:03 brianlow

Does this version still have the bug where the slave half doesn't synch RGB state from master?

Fixed thanks to @derpus-potatus and @at669

AWESOME! Just tried it and it works great! What was the fix out of curiosity? (And my sanity since I spent the last couple of hours on trying to fix that myself)

B-1P avatar Mar 29 '22 06:03 B-1P

@B-1P details here: https://github.com/josefadamcik/SofleKeyboard/issues/124#issuecomment-1025069293

brianlow avatar Mar 29 '22 06:03 brianlow

New keymaps should be moved under the choc directory, as they won't be automatically compiled by CI otherwise.

fauxpark avatar Apr 03 '22 20:04 fauxpark

Thanks @fauxpark, moved new keymaps under choc:

keyboards/sofle/choc/keymaps/default
keyboards/sofle/choc/keymaps/via

brianlow avatar Apr 03 '22 21:04 brianlow

thanks! is there anything left to get this approved and merged?

lttb avatar Jun 01 '22 14:06 lttb

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Sep 24 '22 02:09 github-actions[bot]

What's the status on this?

NULLx76 avatar Sep 24 '22 09:09 NULLx76

Any chance you can get @drashna's suggestions added and can proceed with merging this?

petesmc avatar Oct 10 '22 10:10 petesmc