Brian Low
Brian Low
Glad it has been helpful. Credit goes to the original author Ben Buxton
LGTM, would be great to get this in so there is a good place for Sofle Choc firmware (that has a different hardware config)
I think all feedback has been addressed
Sorry for the review requests, didn't understand how this repo was setup. @mekeor had requested changes and I've implemented
@fauxpark Feedback applied, thanks!
> Ideally, this should be in keyboards/sofle/choc, and not a separate folder. @drashna An earlier review (https://github.com/qmk/qmk_firmware/pull/16736#discussion_r844724538) suggested moving it out because this hardware is incompatible with with the top-level...
@drashna what is the next step for this PR?
@drashna feedback applied. Credit to @duese for the work, thanks!
Thanks for the update. I am happy to update this branch if a repo maintainer is up for sponsoring this PR or there is a concrete path to merging. Let...
Thanks for the feedback I am happy to update this PR if there is a concrete path to merging. My concern is spending time on this only to have the...