Brage Sekse Aarset
Brage Sekse Aarset
Let's see what the workflows say, @NoNameProvided ?
> I did not get the reason why it says "First-time contributors need a maintainer to approve running workflows. [Learn more.](https://docs.github.com/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks)". You have already approved but workflow did not started.....
See [my recent comment](https://github.com/typestack/class-validator/issues/1721#issuecomment-1857290706) in #1721
I think I prefer the `skip` or `skipIf` name for this option. I think `validateIf` is a bit confusing, since you can get it mixed up with the `ValidateIf` decorator.
Handy feature, though!
See [my recent comment](https://github.com/typestack/class-validator/issues/1721#issuecomment-1857290706) in #1721
We are discussing this feature internally right now. Hold on just a little longer, @kevit-kelvin-mandlik and @aoi-umi
I believe this is the best proposal for improving validator conditionality. I think #1579 needs some work to resolve this (see my comments there), but this solution is my preferred...
I suppose you're right about the usage of 24:00 in military contexts. I suppose an option is the only way to let people also use this validator for plain old...
This is quite cool! I can't think of any obvious pitfalls right now, and this seems like a very nice QoL feature. Has this been discussed previously, @NoNameProvided ?