Brage Sekse Aarset comments

Results 177 comments of


                                            Brage Sekse Aarset

isLuhn

Instead of implementing the validation code here, we should use [isLuhnNumber from validator.js](https://github.com/validatorjs/validator.js/blob/72573b3d1d8ab2e6575e6bba1cbe2b01f95f4935/src/lib/isLuhnNumber.js)

feat: add `isISO6391` decorator for language codes

Please fix the test so that we can proceed with this

fix: MinDate & MaxDate constraint message unclear

It would be nice to see the actual date in the error message. Do you want to take a stab at implementing this, @EmirBoyaci?

feature: Add `IsIBANOptions` to `IsIBAN` decorator

You're right, that is a problem with the current standard. We can't do method overloading to solve this, so the only options are to do some rather ugly (not very...

feature: enforce timezone info with isDateString

Yes, you should post it there, since this would require a new validator. I think the answer is going to be no, since the general philosophy of that validator is...

fix: should print max information by default

I agree with @strowk. The logs from testcontainers are noise while tests pass, but useful when tests fail.

docs: update changelog for 0.14.1

Thanks!